Fix task graph fatal for graphs containing restricted tasks
bbc2ae78589b
Actions

Description

Fix task graph fatal for graphs containing restricted tasks

Summary: Fixes T11392. If some tasks are restricted, we only have PHIDs for them, not objects. Just use the PHIDs instead.

Test Plan:

Screen Shot 2016-07-29 at 7.02.29 AM.png (542×952 px, 70 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11392

Differential Revision: https://secure.phabricator.com/D16345

Details

Provenance

epriestley	Authored on Jul 29 2016, 2:02 PM
epriestley	Pushed on Jul 29 2016, 2:21 PM

Reviewer

chad

Differential Revision

D16345: Fix task graph fatal for graphs containing restricted tasks

Parents

rP15c7eb142570: When a task graph has too much stuff, only show adjacent nodes (direct…

Branches

Unknown

Tags

Unknown

Tasks

T11392: Unhandled Exception when opening specific Task while not logged in

Build Status

Buildable 13183
Build 16878: Run Core Tests

Event Timeline

epriestley committed rPbbc2ae78589b: Fix task graph fatal for graphs containing restricted tasks (authored by epriestley).Jul 29 2016, 2:21 PM

epriestley added a task: T11392: Unhandled Exception when opening specific Task while not logged in.

Harbormaster completed building B13183: rPbbc2ae78589b: Fix task graph fatal for graphs containing restricted tasks.Jul 29 2016, 2:22 PM

• dunktang removed an edge: D16345: Fix task graph fatal for graphs containing restricted tasks.Jul 30 2016, 3:38 AM

epriestley added an edge: D16345: Fix task graph fatal for graphs containing restricted tasks.Jul 30 2016, 11:25 AM

epriestley mentioned this in 2016 Week 31 (Very Late July).Jul 30 2016, 12:42 PM

Changes (1)

Path

Size

src/

infrastructure/

graph/

ManiphestTaskGraph.php

rPbbc2ae78589b

View Options

src/infrastructure/graph/ManiphestTaskGraph.php