Page MenuHomePhabricator
Differential D16259

Trigger autocomplete when "@" is typed on German keyboards
ClosedPublic
Actions

Authored by epriestley on Jul 8 2016, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 1:42 AM
Unknown Object (File)
Fri, Jan 24, 5:31 PM
Unknown Object (File)
Fri, Jan 24, 2:40 PM
Unknown Object (File)
Mon, Jan 20, 9:52 AM
Unknown Object (File)
Sun, Jan 19, 5:33 PM
Unknown Object (File)
Sun, Jan 19, 10:38 AM
Unknown Object (File)
Sat, Jan 18, 11:47 AM
Unknown Object (File)
Mon, Jan 6, 2:00 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10252: Username autocompletion doesn't work with some non-US keyboard layouts
Commits
rPa8a9fddb0738: Trigger autocomplete when "@" is typed on German keyboards
Summary

Ref T10252. On the German keyboard layout, you must type "Alt" + "L" to generate an "@" character.

We currently ignore this event, assuming it's a keyboard command. However, I think we can safely continue so that autocomplete works on German layouts.

Test Plan
  • Switched keyboard layout to German.
  • Typed Alt + L to generate an "@".
  • Typed some username text.
  • Got autocompleter.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
16 lines
webroot/
rsrc/
js/
phuix/
6 lines

Diff 39111

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXAutocomplete.js

Loading...
Phabricator · Built by Phacility