Differential D16259

Trigger autocomplete when "@" is typed on German keyboards
ClosedPublic
Actions

Authored by epriestley on Jul 8 2016, 3:20 PM.

Details

Reviewers

chad

Maniphest Tasks

T10252: Username autocompletion doesn't work with some non-US keyboard layouts

Commits

rPa8a9fddb0738: Trigger autocomplete when "@" is typed on German keyboards

Summary

Ref T10252. On the German keyboard layout, you must type "Alt" + "L" to generate an "@" character.

We currently ignore this event, assuming it's a keyboard command. However, I think we can safely continue so that autocomplete works on German layouts.

Test Plan

Switched keyboard layout to German.
Typed Alt + L to generate an "@".
Typed some username text.
Got autocompleter.

Diff Detail

Repository

rP Phabricator

Branch

layout1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12983
Build 16581: Run Core Tests
Build 16580: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39109.Jul 8 2016, 3:20 PM

epriestley retitled this revision from to Trigger autocomplete when "@" is typed on German keyboards.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

epriestley updated this object.Jul 8 2016, 3:23 PM

En fuego

This revision is now accepted and ready to land.Jul 8 2016, 3:23 PM

epriestley mentioned this in T10252: Username autocompletion doesn't work with some non-US keyboard layouts.Jul 8 2016, 3:24 PM

epriestley mentioned this in D16260: Fix "\" keyboard shortcut on German keyboard layouts.Jul 8 2016, 3:32 PM

Closed by commit rPa8a9fddb0738: Trigger autocomplete when "@" is typed on German keyboards (authored by epriestley, committed by epriestley). · Explain WhyJul 8 2016, 3:36 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP444e353700fa: Fix "\" keyboard shortcut on German keyboard layouts.Jul 8 2016, 3:39 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

16 lines

webroot/

rsrc/

js/

phuix/

PHUIXAutocomplete.js

6 lines

Diff 39109

View Options

resources/celerity/map.php