Page MenuHomePhabricator
Differential D16237

Make repository URI creation work regardless of "repository" transaction order
ClosedPublic
Actions

Authored by epriestley on Jul 5 2016, 11:40 PM.
Tags
None
Referenced Files
F14066927: D16237.diff
Tue, Nov 19, 12:32 PM
F14057615: D16237.diff
Sun, Nov 17, 5:14 AM
F14052696: D16237.diff
Fri, Nov 15, 9:44 AM
F14040088: D16237.diff
Mon, Nov 11, 7:22 AM
F14022971: D16237.diff
Wed, Nov 6, 9:13 PM
F14010751: D16237.diff
Thu, Oct 31, 12:11 PM
F14006048: D16237.id.diff
Mon, Oct 28, 12:00 AM
F14004361: D16237.id39057.diff
Sat, Oct 26, 7:13 PM
View All Files
Subscribers
None

Details

Reviewers
avivey
chad
Maniphest Tasks
T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input
Commits
rP921d56efb0f0: Make repository URI creation work regardless of "repository" transaction order
Summary

Fixes T11276. This feels slightly iffy (we attachRepository() here, and also when applying the TYPE_REPOSITORY transaction) but simpler than trying to reorder things.

Test Plan

Created a repository URI with transactions in ["uri", "repository"] order.

Diff Detail

Repository
rP Phabricator
Branch
repo1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12934
Build 16506: Run Core Tests
Build 16505: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39055.Jul 5 2016, 11:40 PM
epriestley retitled this revision from to Make repository URI creation work regardless of "repository" transaction order.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, avivey.
epriestley added a task: T11276: diffusion.uri.edit for creating an object fails depending on order of transactions in input.
epriestley added inline comments.Jul 5 2016, 11:41 PM
src/applications/diffusion/editor/DiffusionURIEditor.php
126

When processing in the other order, we run this part first so the code works.

avivey accepted this revision.Jul 5 2016, 11:44 PM
avivey edited edge metadata.

probably fine

This revision is now accepted and ready to land.Jul 5 2016, 11:44 PM
Closed by commit rP921d56efb0f0: Make repository URI creation work regardless of "repository" transaction order (authored by epriestley, committed by epriestley). · Explain WhyJul 5 2016, 11:45 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in rPa5b26104f6eb: Fix an issue with creating new Repository URIs via the Web UI.Jul 9 2016, 12:56 PM
epriestley mentioned this in rP46ceba728fee: (stable) Fix an issue with creating new Repository URIs via the Web UI.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
editor/
5 lines

Diff 39055

View Options

src/applications/diffusion/editor/DiffusionURIEditor.php

Loading...
Phabricator · Built by Phacility