Page MenuHomePhabricator
Differential D16114

Have modular transactions fall back correctly when selecting feed titles
ClosedPublic
Actions

Authored by epriestley on Jun 14 2016, 5:58 PM.
Tags
None
Referenced Files
F13183164: D16114.id38774.diff
Fri, May 10, 7:11 AM
Unknown Object (File)
Tue, May 7, 5:06 AM
Unknown Object (File)
Sun, May 5, 12:34 PM
Unknown Object (File)
Fri, May 3, 2:26 AM
Unknown Object (File)
Wed, May 1, 3:02 PM
Unknown Object (File)
Mon, Apr 29, 11:59 PM
Unknown Object (File)
Mon, Apr 29, 11:59 PM
Unknown Object (File)
Mon, Apr 29, 11:56 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9789: Make it easier to write custom transaction types
Commits
rPe44d92babcca: Have modular transactions fall back correctly when selecting feed titles
Summary

Ref T9789. Falling back to parent:: is better, and fixes older-style feed stories for Pastes, like "added a comment".

Test Plan

Viewed a comment feed story about a paste.

Diff Detail

Repository
rP Phabricator
Branch
feedtitle
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12649
Build 16069: Run Core Tests
Build 16068: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38773.Jun 14 2016, 5:58 PM
epriestley retitled this revision from to Have modular transactions fall back correctly when selecting feed titles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9789: Make it easier to write custom transaction types.
chad accepted this revision.Jun 14 2016, 6:03 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2016, 6:03 PM
epriestley added a comment.Jun 14 2016, 6:04 PM

(Looking at that test failure...)

epriestley added a comment.Jun 14 2016, 6:05 PM

Hrrrm, doesn't reproduce locally.

epriestley added a comment.Jun 14 2016, 6:07 PM

Also didn't reproduce when I restarted the build. v. spooooooky

Closed by commit rPe44d92babcca: Have modular transactions fall back correctly when selecting feed titles (authored by epriestley, committed by epriestley). · Explain WhyJun 14 2016, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
storage/
2 lines

Diff 38773

View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

Loading...
Phabricator · Built by Phacility