Page MenuHomePhabricator

Have modular transactions fall back correctly when selecting feed titles
ClosedPublic

Authored by epriestley on Jun 14 2016, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 1:54 PM
Unknown Object (File)
Feb 8 2024, 6:15 AM
Unknown Object (File)
Feb 3 2024, 10:50 AM
Unknown Object (File)
Jan 28 2024, 9:14 AM
Unknown Object (File)
Jan 7 2024, 6:24 PM
Unknown Object (File)
Dec 29 2023, 6:57 AM
Unknown Object (File)
Dec 27 2023, 7:30 AM
Unknown Object (File)
Dec 27 2023, 7:30 AM
Subscribers
None

Details

Summary

Ref T9789. Falling back to parent:: is better, and fixes older-style feed stories for Pastes, like "added a comment".

Test Plan

Viewed a comment feed story about a paste.

Diff Detail

Repository
rP Phabricator
Branch
feedtitle
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12649
Build 16069: Run Core Tests
Build 16068: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Have modular transactions fall back correctly when selecting feed titles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 14 2016, 6:03 PM

(Looking at that test failure...)

Hrrrm, doesn't reproduce locally.

Also didn't reproduce when I restarted the build. v. spooooooky

This revision was automatically updated to reflect the committed changes.