Have modular transactions fall back correctly when selecting feed titles
ClosedPublic
Actions

Authored by epriestley on Jun 14 2016, 5:58 PM.

Details

Reviewers

chad

Maniphest Tasks

T9789: Make it easier to write custom transaction types

Commits

rPe44d92babcca: Have modular transactions fall back correctly when selecting feed titles

Summary

Ref T9789. Falling back to parent:: is better, and fixes older-style feed stories for Pastes, like "added a comment".

Test Plan

Viewed a comment feed story about a paste.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38773.Jun 14 2016, 5:58 PM

epriestley retitled this revision from to Have modular transactions fall back correctly when selecting feed titles.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9789: Make it easier to write custom transaction types.

chad accepted this revision.Jun 14 2016, 6:03 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 14 2016, 6:03 PM

(Looking at that test failure...)

Hrrrm, doesn't reproduce locally.

Also didn't reproduce when I restarted the build. v. spooooooky

Closed by commit rPe44d92babcca: Have modular transactions fall back correctly when selecting feed titles (authored by epriestley, committed by epriestley). · Explain WhyJun 14 2016, 6:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorModularTransaction.php

2 lines

Diff 38774

View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

Have modular transactions fall back correctly when selecting feed titlesClosedPublicActions