Use "internal" smoothing for code diffs in Arcanist
ClosedPublic
Actions

Authored by epriestley on Jun 7 2016, 8:45 PM.

Details

Reviewers

chad

Maniphest Tasks

T7643: Improve prose diffs (was: description changes don't generate usable diffs)

Commits

rARCc75b671b221a: Use "internal" smoothing for code diffs in Arcanist

Summary

Ref T7643. This moves the prefix/suffix smoothing behavior back to the old one, which seems better for code diffs.

Test Plan

arc unit --everything

Diff Detail

Repository

rARC Arcanist

Branch

prose11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12548
Build 15919: Run Core Tests
Build 15918: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38676.Jun 7 2016, 8:45 PM

epriestley retitled this revision from to Use "internal" smoothing for code diffs in Arcanist.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T7643: Improve prose diffs (was: description changes don't generate usable diffs).

chad accepted this revision.Jun 7 2016, 8:49 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2016, 8:49 PM

Closed by commit rARCc75b671b221a: Use "internal" smoothing for code diffs in Arcanist (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2016, 9:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

difference/

ArcanistDiffUtils.php

2 lines

Diff 38676

View Options

src/difference/ArcanistDiffUtils.php

Use "internal" smoothing for code diffs in ArcanistClosedPublicActions