Paths

Table of Contentst

Differential D11297

Add Videos to Remarkup
ClosedPublic
Actions

Authored by epriestley on Jan 9 2015, 5:00 PM.

Tags

Referenced Files

	Unknown Object (File)
	Mon, Dec 23, 8:25 AM

	Unknown Object (File)
	Fri, Dec 20, 8:23 PM

	Unknown Object (File)
	Fri, Dec 20, 3:47 PM

	Unknown Object (File)
	Sat, Dec 14, 5:20 PM

	Unknown Object (File)
	Fri, Dec 13, 9:33 AM

	Unknown Object (File)
	Thu, Dec 12, 2:31 PM

	Unknown Object (File)
	Wed, Dec 11, 5:40 PM

	Unknown Object (File)
	Mon, Dec 9, 6:52 PM

Subscribers

Details

Reviewers

chad
nateguchi2

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6916: Allow video embed in remarkup

Commits

rP411cf1345763: Add Videos to Remarkup

Summary

Ref T6916. Added video to remarkup using D7156 as reference.

Test Plan

Viewed video files (MP4, Ogg) in Safari, Chrome, Firefox (some don't work, e.g., OGG in Safari, but nothing we can really do about that).
Used alt.
Used autoplay.
Used loop.
Used media=audio.
Viewed file detail page.

Diff Detail

Repository

Branch

video1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12542
Build 15909: Run Core Tests
Build 15908: arc lint + arc unit

Event Timeline

nateguchi2 updated this revision to Diff 27144.Jan 9 2015, 5:00 PM

nateguchi2 retitled this revision from to Add Videos to Remarkup.

nateguchi2 updated this object.

nateguchi2 edited the test plan for this revision. (Show Details)

nateguchi2 added a reviewer: epriestley.

nateguchi2 set the repository for this revision to rP Phabricator.

nateguchi2 added a project: Remarkup.

nateguchi2 changed the visibility from "Public (No Login Required)" to "All Users".

Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptJan 9 2015, 5:00 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

nateguchi2 mentioned this in T6916: Allow video embed in remarkup.Jan 9 2015, 5:03 PM

joshuaspence updated this object.Feb 26 2015, 2:10 AM

joshuaspence edited edge metadata.

joshuaspence added a task: T6916: Allow video embed in remarkup.

joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 5:54 AM

ivo added a subscriber: ivo.Sep 16 2015, 11:57 AM

epriestley commandeered this revision.Jun 7 2016, 5:07 PM

epriestley edited reviewers, added: nateguchi2; removed: epriestley.

Herald edited edge metadata. · View Herald TranscriptJun 7 2016, 5:07 PM

Handle maybe-audio, maybe-video files (like "application/ogg").
Clean up display of file properties in Files ("Image", "Audio", "Video", etc) a little.
Add media for media="audio", to explicitly render ambiguous files as audio.
Clean up and document attributes.

Herald edited edge metadata. · View Herald TranscriptJun 7 2016, 5:50 PM

Remove debugging code for file mime types.

Herald edited edge metadata. · View Herald TranscriptJun 7 2016, 5:52 PM

epriestley updated this object.Jun 7 2016, 5:53 PM

epriestley edited the test plan for this revision. (Show Details)

epriestley edited edge metadata.

That Test Plan prose diff went very interestingly.

asherkin changed the visibility from "All Users" to "Public (No Login Required)".Jun 7 2016, 6:25 PM

epriestley mentioned this in D16071: Improve prose diff smoothing rules for whitespace and prefix/suffix changes.Jun 7 2016, 7:15 PM

epriestley mentioned this in rPHU6d1eea50fb9a: Improve prose diff smoothing rules for whitespace and prefix/suffix changes.Jun 7 2016, 7:58 PM

The diff should be a bit more reasonable now:

Screen Shot 2016-06-07 at 1.04.41 PM.png (371×631 px, 39 KB)

chad accepted this revision.Jun 7 2016, 8:19 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2016, 8:19 PM

Closed by commit rP411cf1345763: Add Videos to Remarkup (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2016, 8:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

10 lines

src/

applications/

files/

config/

PhabricatorFilesConfigOptions.php

43 lines

controller/

PhabricatorFileInfoController.php

52 lines

markup/

PhabricatorEmbedFileRemarkupRule.php

59 lines

storage/

PhabricatorFile.php

10 lines

docs/

user/

userguide/

remarkup.diviner

19 lines

webroot/

rsrc/

css/

core/

11 lines

phui/

phui-property-list-view.css

7 lines

Diff 38670

resources/celerity/map.php

Loading...

src/applications/files/config/PhabricatorFilesConfigOptions.php

Loading...

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/docs/user/userguide/remarkup.diviner

Loading...

webroot/rsrc/css/core/remarkup.css

Loading...

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...