HomePhabricator

Add Videos to Remarkup

Description

Add Videos to Remarkup

Summary: Ref T6916. Added video to remarkup using D7156 as reference.

Test Plan:

  • Viewed video files (MP4, Ogg) in Safari, Chrome, Firefox (some don't work, e.g., OGG in Safari, but nothing we can really do about that).
  • Used alt.
  • Used autoplay.
  • Used loop.
  • Used media=audio.
  • Viewed file detail page.

Reviewers: nateguchi2, chad, Blessed Reviewers

Reviewed By: chad, Blessed Reviewers

Subscribers: asherkin, ivo, joshuaspence, Korvin, epriestley

Tags: Remarkup

Maniphest Tasks: T6916

Differential Revision: https://secure.phabricator.com/D11297

Details

Provenance
epriestleyAuthored on Jun 7 2016, 5:26 PM
epriestleyPushed on Jun 7 2016, 8:20 PM
Reviewer
Blessed Reviewers
Differential Revision
D11297: Add Videos to Remarkup
Parents
rPf0eb6f4fe080: Add client-side check for protocol mismatch
Branches
Unknown
Tags
Unknown
Tasks
T6916: Allow video embed in remarkup
Build Status
Buildable 12545
Build 15913: Run Core Tests

Event Timeline

i feel like harbormaster build failures should just automatically use that macro.

That one's actually legit-ish, I think -- weird interaction between prose diff changes and existing diff test cases.

I was saving that file for this day!