Page MenuHomePhabricator
Differential D11297

Add Videos to Remarkup
ClosedPublic
Actions

Authored by epriestley on Jan 9 2015, 5:00 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 11, 7:47 AM
Unknown Object (File)
Fri, Apr 5, 1:24 PM
Unknown Object (File)
Thu, Apr 4, 10:01 AM
Unknown Object (File)
Sun, Mar 31, 10:10 PM
Unknown Object (File)
Sun, Mar 31, 10:10 PM
Unknown Object (File)
Sun, Mar 31, 10:10 PM
Unknown Object (File)
Feb 13 2024, 1:35 PM
Unknown Object (File)
Feb 5 2024, 6:43 PM
View All Files
Subscribers
asherkin
epriestley
ivo
joshuaspence
Korvin

Details

Reviewers
chad
nateguchi2
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6916: Allow video embed in remarkup
Commits
rP411cf1345763: Add Videos to Remarkup
Summary

Ref T6916. Added video to remarkup using D7156 as reference.

Test Plan
  • Viewed video files (MP4, Ogg) in Safari, Chrome, Firefox (some don't work, e.g., OGG in Safari, but nothing we can really do about that).
  • Used alt.
  • Used autoplay.
  • Used loop.
  • Used media=audio.
  • Viewed file detail page.

Diff Detail

Event Timeline

nateguchi2 updated this revision to Diff 27144.Jan 9 2015, 5:00 PM
nateguchi2 retitled this revision from to Add Videos to Remarkup.
nateguchi2 updated this object.
nateguchi2 edited the test plan for this revision. (Show Details)
nateguchi2 added a reviewer: epriestley.
nateguchi2 set the repository for this revision to rP Phabricator.
nateguchi2 added a project: Remarkup.
nateguchi2 changed the visibility from "Public (No Login Required)" to "All Users".
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptJan 9 2015, 5:00 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
nateguchi2 mentioned this in T6916: Allow video embed in remarkup.Jan 9 2015, 5:03 PM
joshuaspence updated this object.Feb 26 2015, 2:10 AM
joshuaspence edited edge metadata.
joshuaspence added a task: T6916: Allow video embed in remarkup.
joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 5:54 AM
ivo added a subscriber: ivo.Sep 16 2015, 11:57 AM
epriestley commandeered this revision.Jun 7 2016, 5:07 PM
epriestley edited reviewers, added: nateguchi2; removed: epriestley.
Herald edited edge metadata. · View Herald TranscriptJun 7 2016, 5:07 PM
epriestley updated this revision to Diff 38669.Jun 7 2016, 5:50 PM
epriestley edited edge metadata.
  • Handle maybe-audio, maybe-video files (like "application/ogg").
  • Clean up display of file properties in Files ("Image", "Audio", "Video", etc) a little.
  • Add media for media="audio", to explicitly render ambiguous files as audio.
  • Clean up and document attributes.
Herald edited edge metadata. · View Herald TranscriptJun 7 2016, 5:50 PM
epriestley updated this revision to Diff 38670.Jun 7 2016, 5:52 PM
epriestley edited edge metadata.
  • Remove debugging code for file mime types.
Herald edited edge metadata. · View Herald TranscriptJun 7 2016, 5:52 PM
epriestley updated this object.Jun 7 2016, 5:53 PM
epriestley edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
asherkin added a subscriber: asherkin.Jun 7 2016, 6:24 PM

That Test Plan prose diff went very interestingly.

asherkin changed the visibility from "All Users" to "Public (No Login Required)".Jun 7 2016, 6:25 PM
epriestley mentioned this in D16071: Improve prose diff smoothing rules for whitespace and prefix/suffix changes.Jun 7 2016, 7:15 PM
epriestley mentioned this in rPHU6d1eea50fb9a: Improve prose diff smoothing rules for whitespace and prefix/suffix changes.Jun 7 2016, 7:58 PM
epriestley added a comment.Jun 7 2016, 8:05 PM

The diff should be a bit more reasonable now:

Screen Shot 2016-06-07 at 1.04.41 PM.png (371×631 px, 39 KB)

chad accepted this revision.Jun 7 2016, 8:19 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 8:19 PM
Closed by commit rP411cf1345763: Add Videos to Remarkup (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2016, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
config/
16 lines
controller/
31 lines
markup/
32 lines
storage/
10 lines
webroot/
rsrc/
css/
core/
8 lines
phui/
8 lines

Diff 27144

View Options

src/applications/files/config/PhabricatorFilesConfigOptions.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility