Page MenuHomePhabricator

Restore edit UI for "Import Only" in Subversion
ClosedPublic

Authored by epriestley on May 11 2016, 12:14 AM.
Tags
None
Referenced Files
F13233774: D15883.diff
Tue, May 21, 2:34 AM
F13224739: D15883.id38263.diff
Sun, May 19, 10:32 AM
F13211992: D15883.diff
Fri, May 17, 6:18 AM
F13206530: D15883.diff
Wed, May 15, 11:42 AM
F13206024: D15883.id38263.diff
Wed, May 15, 4:45 AM
F13199384: D15883.id38265.diff
Mon, May 13, 2:15 PM
F13195631: D15883.diff
Sun, May 12, 10:31 PM
F13190668: D15883.id38251.diff
Sat, May 11, 1:07 PM
Subscribers
None

Details

Summary

Ref T10923. Although I'd ideally like to get rid of this eventually, keep it around for now.

Test Plan
  • Edited value for an SVN repository.
  • Observed no panel present for a Git repository.

Diff Detail

Repository
rP Phabricator
Branch
dxdoc13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 12126
Build 15292: Run Core Tests
Build 15291: arc lint + arc unit

Unit TestsFailed

TimeTest
78 msPhabricatorChangeParserTestCase::Unknown Unit Message ("")
EXCEPTION (PhutilAggregateException): Multiple exceptions were raised during test execution. - Execution: LiskEphemeralObjectException: - Shutdown: Exception: Process exited with an open transaction! The transaction will be implicitly rolled back. Calls to openTransaction() must always be paired with a call to saveTransaction() or killTransaction().
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
6 assertions passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 322 Passed)

Event Timeline

epriestley retitled this revision from to Restore edit UI for "Import Only" in Subversion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

this also has bad unit tests? not related?

This revision is now accepted and ready to land.May 11 2016, 3:07 AM
epriestley edited edge metadata.
  • Rebase for test fix.
This revision was automatically updated to reflect the committed changes.