Page MenuHomePhabricator

Correct RepositoryURI schema and propagate `adjust` exit code correctly
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:07 PM.
Tags
None
Referenced Files
F15444128: D15746.id37946.diff
Thu, Mar 27, 8:00 AM
F15422842: D15746.id37946.diff
Sat, Mar 22, 11:02 AM
F15392519: D15746.id.diff
Sat, Mar 15, 3:40 PM
F15392256: D15746.id37945.diff
Sat, Mar 15, 2:07 PM
F15390760: D15746.diff
Sat, Mar 15, 6:33 AM
F15389356: D15746.id.diff
Sat, Mar 15, 5:09 AM
F15345554: D15746.id37946.diff
Mon, Mar 10, 11:23 AM
Unknown Object (File)
Mar 1 2025, 2:11 AM
Subscribers
None

Details

Summary

Fixes T10830.

  • The return code from storage adjust did not propagate correct.
  • There was one column issue which I missed the first time around because I had a bunch of unrelated stuff locally.
Test Plan
  • Ran bin/storage upgrade -f with failures, used echo $? to make sure it exited nonzero.
  • Got fully clean bin/storage adjust by dropping all my extra local tables.

Diff Detail

Repository
rP Phabricator
Branch
adjust2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11818
Build 14825: Run Core Tests
Build 14824: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Correct RepositoryURI schema and propagate `adjust` exit code correctly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.