Page MenuHomePhabricator

Correct RepositoryURI schema and propagate `adjust` exit code correctly
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:07 PM.
Tags
None
Referenced Files
F17657620: D15746.diff
Sat, Jul 12, 12:26 PM
Unknown Object (File)
Fri, Jun 20, 9:03 AM
Unknown Object (File)
Wed, Jun 18, 2:24 PM
Unknown Object (File)
Tue, Jun 17, 1:35 PM
Unknown Object (File)
Jun 3 2025, 3:23 AM
Unknown Object (File)
May 27 2025, 11:03 AM
Unknown Object (File)
May 8 2025, 10:00 PM
Unknown Object (File)
Apr 25 2025, 6:12 PM
Subscribers
None

Details

Summary

Fixes T10830.

  • The return code from storage adjust did not propagate correct.
  • There was one column issue which I missed the first time around because I had a bunch of unrelated stuff locally.
Test Plan
  • Ran bin/storage upgrade -f with failures, used echo $? to make sure it exited nonzero.
  • Got fully clean bin/storage adjust by dropping all my extra local tables.

Diff Detail

Repository
rP Phabricator
Branch
adjust2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11818
Build 14825: Run Core Tests
Build 14824: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Correct RepositoryURI schema and propagate `adjust` exit code correctly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.