Page MenuHomePhabricator

Correct RepositoryURI schema and propagate `adjust` exit code correctly
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 6, 2:56 PM
Unknown Object (File)
Sun, Jul 5, 11:39 AM
Unknown Object (File)
Apr 5 2026, 6:33 PM
Unknown Object (File)
Apr 5 2026, 6:33 PM
Unknown Object (File)
Mar 30 2026, 3:33 AM
Unknown Object (File)
Mar 29 2026, 12:31 PM
Unknown Object (File)
Mar 15 2026, 4:10 AM
Unknown Object (File)
Mar 10 2026, 12:52 AM
Subscribers
None

Details

Summary

Fixes T10830.

  • The return code from storage adjust did not propagate correct.
  • There was one column issue which I missed the first time around because I had a bunch of unrelated stuff locally.
Test Plan
  • Ran bin/storage upgrade -f with failures, used echo $? to make sure it exited nonzero.
  • Got fully clean bin/storage adjust by dropping all my extra local tables.

Diff Detail

Repository
rP Phabricator
Branch
adjust2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11818
Build 14825: Run Core Tests
Build 14824: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Correct RepositoryURI schema and propagate `adjust` exit code correctly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.