Page MenuHomePhabricator

Correct RepositoryURI schema and propagate `adjust` exit code correctly
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:07 PM.
Tags
None
Referenced Files
F18902274: D15746.id.diff
Nov 8 2025, 12:30 AM
F18874953: D15746.id37946.diff
Nov 5 2025, 4:23 PM
F18856996: D15746.diff
Nov 1 2025, 12:33 PM
F18816898: D15746.id37945.diff
Oct 21 2025, 10:22 AM
F18782552: D15746.id.diff
Oct 13 2025, 1:58 AM
F18754935: D15746.id37945.diff
Oct 5 2025, 2:28 AM
F18738065: D15746.diff
Oct 1 2025, 1:56 PM
F18675125: D15746.id37945.diff
Sep 25 2025, 5:19 PM
Subscribers
None

Details

Summary

Fixes T10830.

  • The return code from storage adjust did not propagate correct.
  • There was one column issue which I missed the first time around because I had a bunch of unrelated stuff locally.
Test Plan
  • Ran bin/storage upgrade -f with failures, used echo $? to make sure it exited nonzero.
  • Got fully clean bin/storage adjust by dropping all my extra local tables.

Diff Detail

Repository
rP Phabricator
Branch
adjust2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11818
Build 14825: Run Core Tests
Build 14824: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Correct RepositoryURI schema and propagate `adjust` exit code correctly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.