Page MenuHomePhabricator

Correct RepositoryURI schema and propagate `adjust` exit code correctly
ClosedPublic

Authored by epriestley on Apr 18 2016, 3:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2024, 7:49 AM
Unknown Object (File)
Feb 7 2024, 9:56 PM
Unknown Object (File)
Feb 3 2024, 9:50 AM
Unknown Object (File)
Jan 23 2024, 8:11 PM
Unknown Object (File)
Jan 15 2024, 6:33 PM
Unknown Object (File)
Jan 8 2024, 7:33 AM
Unknown Object (File)
Dec 27 2023, 6:48 AM
Unknown Object (File)
Dec 27 2023, 6:48 AM
Subscribers
None

Details

Summary

Fixes T10830.

  • The return code from storage adjust did not propagate correct.
  • There was one column issue which I missed the first time around because I had a bunch of unrelated stuff locally.
Test Plan
  • Ran bin/storage upgrade -f with failures, used echo $? to make sure it exited nonzero.
  • Got fully clean bin/storage adjust by dropping all my extra local tables.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Correct RepositoryURI schema and propagate `adjust` exit code correctly.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 18 2016, 3:11 PM
This revision was automatically updated to reflect the committed changes.