Details

Reviewers

Group Reviewers

Maniphest Tasks

Summary

/ is not a root path on Windows and when using commands like arc version it resolves to the current working directory. This patch replaces the default / with %HOMEDRIVE% to fix the issue.

This patch fixes T8291 when combined with D15675.

Test Plan

Manual verification on Windows.

Diff Detail

Repository

rPHU libphutil

Branch

windows-root-path

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 11638
Build 14560: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	43 ms	FileFinderTestCase::Unknown Unit Message ("") EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path "./exclude" -o -path "subdir.txt" ")" -prune -o "(" -name ".txt" ")" "(" -path "" ")" -print0
	26 ms	FileFinderTestCase::Unknown Unit Message ("") EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path "./exclude" -o -path "subdir.txt" ")" -prune -o -type "f" "(" -name "test" ")" "(" -path "*" ")" -print0
	25 ms	FileFinderTestCase::Unknown Unit Message ("") EXCEPTION (CommandException): Command failed with error #2! COMMAND find . "(" -path "./exclude" -o -path "subdir.txt" ")" -prune -o -type "f" "(" -name ".txt" ")" "(" -path "/include_dir.txt/subdir.txt/alsoinclude.txt" ")" -print0
	28 ms	FileFinderTestCase::Unknown Unit Message ("") EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path "./exclude" -o -path "subdir.txt" ")" -prune -o -type "f" "(" -name ".txt" ")" "(" -path "" ")" -print0
	27 ms	FileFinderTestCase::Unknown Unit Message ("") EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path "./exclude" -o -path "subdir.txt" ")" -prune -o -type "f" "(" -name ".txt" ")" "(" -path "" ")" -print0
		View Full Test Results (13 Failed · 15 Passed)

Event Timeline

BYK updated this revision to Diff 37769.Apr 10 2016, 4:04 PM

BYK retitled this revision from to Fix root path finding on Windows.

BYK updated this object.

BYK edited the test plan for this revision. (Show Details)

BYK added a reviewer: epriestley.

BYK added a task: T8291: arc version fails on Windows.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 10 2016, 4:04 PM

Herald added a subscriber: Korvin. · View Herald Transcript

eadler added a subscriber: eadler.Apr 10 2016, 5:40 PM

eadler added inline comments.

src/filesystem/Filesystem.php
743–745	won't this fail if `arc` is run on a project checked out to a drive other than `%HOMEDRIVE%`?

BYK added inline comments.Apr 10 2016, 5:55 PM

src/filesystem/Filesystem.php
743–745	Possibly. That said there's not reliable equivalent of `/` on Windows AFAIK. If you think getting the install drive for `arc` is a better option, I can update accordingly. Btw. this section is gonna change substantially since there are some other issues I realized when fixing tests. Updating coming soon.