Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T8291: arc version fails on Windows
Manual verification on Windows.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- windows-root-path
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 11743 Build 14712: arc lint + arc unit
Event Timeline
src/filesystem/Filesystem.php | ||
---|---|---|
754–756 | won't this fail if arc is run on a project checked out to a drive other than %HOMEDRIVE%? |
src/filesystem/Filesystem.php | ||
---|---|---|
754–756 | Possibly. That said there's not reliable equivalent of / on Windows AFAIK. If you think getting the install drive for arc is a better option, I can update accordingly. Btw. this section is gonna change substantially since there are some other issues I realized when fixing tests. Updating coming soon. |