Page MenuHomePhabricator
Differential D15500

Unbreak regex filename search
ClosedPublic
Actions

Authored by vlada on Mar 20 2016, 2:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 9:39 PM
Unknown Object (File)
Tue, Dec 17, 6:57 AM
Unknown Object (File)
Sun, Dec 15, 4:48 PM
Unknown Object (File)
Thu, Dec 12, 12:43 AM
Unknown Object (File)
Wed, Dec 11, 8:01 PM
Unknown Object (File)
Thu, Nov 28, 7:33 AM
Unknown Object (File)
Sat, Nov 23, 5:48 PM
Unknown Object (File)
Oct 21 2024, 8:43 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP130e1d1f68a4: Unbreak regex filename search
Summary

D9087 adds a nice typeahead but breaks the existing regex
search by quoting the pattern. Ideally, this change won't break the
typeahead, which as far as I can tell doesn't use the pattern
argument.

Test Plan

Not yet.
RFC as to whether this change makes sense, will fix my local setup and resend if so.

Diff Detail

Repository
rP Phabricator
Branch
unquote (branched from master)
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 11230
Build 13943: arc lint + arc unit

Event Timeline

vlada updated this revision to Diff 37366.Mar 20 2016, 2:13 PM
vlada retitled this revision from to Unbreak regex filename search.
vlada updated this object.
vlada edited the test plan for this revision. (Show Details)
vlada added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 20 2016, 2:13 PM
Herald added a subscriber: Korvin. · View Herald Transcript
vlada edited the test plan for this revision. (Show Details)Mar 20 2016, 2:14 PM
vlada edited edge metadata.
epriestley edited edge metadata.Mar 20 2016, 2:17 PM

I think this is alright. This should be a little cleaner:

$pattern = '('.$pattern.')';
vlada updated this revision to Diff 37367.Mar 20 2016, 4:33 PM
vlada edited edge metadata.

change as per code review

epriestley accepted this revision.Mar 20 2016, 5:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2016, 5:15 PM
Closed by commit rP130e1d1f68a4: Unbreak regex filename search (authored by vlada, committed by epriestley). · Explain WhyMar 20 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
conduit/
3 lines

Diff 37367

View Options

src/applications/diffusion/conduit/DiffusionQueryPathsConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility