D9087 adds a nice typeahead but breaks the existing regex
search by quoting the pattern. Ideally, this change won't break the
typeahead, which as far as I can tell doesn't use the pattern
argument.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP130e1d1f68a4: Unbreak regex filename search
Not yet.
RFC as to whether this change makes sense, will fix my local setup and resend if so.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- unquote (branched from master)
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 11229 Build 13942: arc lint + arc unit
Event Timeline
Comment Actions
I think this is alright. This should be a little cleaner:
$pattern = '('.$pattern.')';