Page MenuHomePhabricator

Add a SublimeText-style repository typeahead

Authored by epriestley on May 13 2014, 3:10 AM.
Referenced Files
Unknown Object (File)
Mon, Mar 27, 11:25 PM
Unknown Object (File)
Mon, Mar 27, 11:24 PM
Unknown Object (File)
Mon, Mar 27, 11:19 PM
Unknown Object (File)
Mon, Mar 27, 11:07 PM
Unknown Object (File)
Mon, Mar 27, 10:06 PM
Unknown Object (File)
Sun, Mar 26, 4:28 AM
Unknown Object (File)
Sat, Mar 18, 12:11 AM
Unknown Object (File)
Wed, Mar 15, 8:00 PM



Allows you to quickly search for files within a repository. Roughly:

  • We build a big tree of everything and ship it to the client.
  • The client implements a bunch of Sublime-ish magic to find paths.
Test Plan

Screen_Shot_2014-05-12_at_7.42.54_PM.png (1×1 px, 295 KB)

Diff Detail

rP Phabricator
Lint Skipped
Tests Skipped

Event Timeline

epriestley retitled this revision from to Add a SublimeText-style repository typeahead.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a subscriber: zeeg.
btrahan edited edge metadata.



is purging the cache necessary? i'd hope in practice this isn't necessary, and otherwise i'd guess we're need an LRU-style cache with a memory limit or something to keep performance in line.

This revision is now accepted and ready to land.May 13 2014, 9:03 PM

This will probably need some tweaks (and if your repository has like 100K files in it I'm not sure how usable it will be) but we can see what issues we hit. For Phabricator-sized repos it feels pretty good to me.


It shouldn't be necessary, but in theory a user can leave the page open for a day and type "a", "aa", "ab", etc., and potentially use a lot of memory. During normal use this shouldn't matter but I trust users to be inventive when it comes to this kind of thing.

epriestley updated this revision to Diff 21637.

Closed by commit rP436f0563e81f (authored by @epriestley).