Page MenuHomePhabricator

Properly URL encode branches in `arc browse --branch ...`
ClosedPublic

Authored by epriestley on Mar 4 2016, 11:51 PM.
Tags
None
Referenced Files
F15411414: D15397.id37123.diff
Wed, Mar 19, 9:17 AM
F15411406: D15397.id.diff
Wed, Mar 19, 9:17 AM
F15401483: D15397.id37123.diff
Mon, Mar 17, 5:54 PM
F15398896: D15397.diff
Mon, Mar 17, 1:52 AM
F15393954: D15397.id37123.diff
Sat, Mar 15, 11:18 PM
F15393953: D15397.id.diff
Sat, Mar 15, 11:18 PM
F15386146: D15397.id37124.diff
Sat, Mar 15, 12:07 AM
F15336319: D15397.id37124.diff
Sat, Mar 8, 6:41 PM
Subscribers
None

Details

Summary

Fixes T10511. If you arc browse --branch x/y/z, we do not encode the URI properly.

Test Plan

Ran arc browse --branch x/y/z/ something.c.

Before, got an error about "x" does not exist. This is wrong; the error should be about "x/y/z".

After, got the proper error:

Screen Shot 2016-03-04 at 3.49.14 PM.png (775×1 px, 92 KB)

Diff Detail

Repository
rARC Arcanist
Branch
branchencode
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10982
Build 13567: Run Core Tests
Build 13566: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Properly URL encode branches in `arc browse --branch ...`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Mar 4 2016, 11:52 PM
This revision was automatically updated to reflect the committed changes.