Properly URL encode branches in `arc browse --branch ...`
ClosedPublic
Actions

Authored by epriestley on Mar 4 2016, 11:51 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T10511: arc browse doesn't percent encode slashes in branch names

Commits

rARC1439aaa87183: (stable) Promote 2016 Week 10
rARC3876d9358390: Properly URL encode branches in `arc browse --branch ...`

Summary

Fixes T10511. If you arc browse --branch x/y/z, we do not encode the URI properly.

Test Plan

Ran arc browse --branch x/y/z/ something.c.

Before, got an error about "x" does not exist. This is wrong; the error should be about "x/y/z".

After, got the proper error:

Screen Shot 2016-03-04 at 3.49.14 PM.png (775×1 px, 92 KB)

Diff Detail

Repository

rARC Arcanist

Branch

branchencode

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10982
Build 13567: Run Core Tests
Build 13566: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37123.Mar 4 2016, 11:51 PM

epriestley retitled this revision from to Properly URL encode branches in `arc browse --branch ...`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10511: arc browse doesn't percent encode slashes in branch names.

avivey accepted this revision.Mar 4 2016, 11:52 PM

avivey added a reviewer: avivey.

This revision is now accepted and ready to land.Mar 4 2016, 11:52 PM

Closed by commit rARC3876d9358390: Properly URL encode branches in `arc browse --branch ...` (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2016, 11:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBrowseWorkflow.php

1 line

Diff 37123

View Options

src/workflow/ArcanistBrowseWorkflow.php

Properly URL encode branches in `arc browse --branch ...`ClosedPublicActions