Page MenuHomePhabricator
Differential D15374

Fix spaces UI in PHUIHeaderView
ClosedPublic
Actions

Authored by chad on Mar 1 2016, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 11:48 PM
Unknown Object (File)
Mon, Apr 22, 12:46 PM
Unknown Object (File)
Wed, Apr 17, 5:55 PM
Unknown Object (File)
Thu, Apr 11, 8:01 AM
Unknown Object (File)
Tue, Apr 2, 10:51 AM
Unknown Object (File)
Fri, Mar 29, 12:23 PM
Unknown Object (File)
Fri, Mar 29, 10:45 AM
Unknown Object (File)
Mar 5 2024, 9:53 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10485: Ponder title size look weird compared to Space title size
Commits
Restricted Diffusion Commit
rP21f8323612cb: Fix spaces UI in PHUIHeaderView
Summary

This should consistenly apply the styling regardless of font or size of the Header. Fixes T10485

Test Plan

Visit a Task and a Countdown in a different Space.

Diff Detail

Repository
rP Phabricator
Branch
phui-header (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10924
Build 13479: Run Core Tests
Build 13478: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37067.Mar 1 2016, 7:45 PM
chad retitled this revision from to Fix spaces UI in PHUIHeaderView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10485: Ponder title size look weird compared to Space title size.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2016, 7:45 PM
epriestley accepted this revision.Mar 1 2016, 7:46 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 7:46 PM
Closed by commit rP21f8323612cb: Fix spaces UI in PHUIHeaderView (authored by chad, committed by chad). · Explain WhyMar 1 2016, 7:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
8 lines
webroot/
rsrc/
css/
phui/
8 lines

Diff 37067

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility