Page MenuHomePhabricator
Differential D15374

Fix spaces UI in PHUIHeaderView
ClosedPublic
Actions

Authored by chad on Mar 1 2016, 7:45 PM.
Tags
None
Referenced Files
F18958447: D15374.diff
Nov 13 2025, 4:38 AM
F18835800: D15374.id.diff
Oct 26 2025, 6:54 PM
F18773117: D15374.id37068.diff
Oct 9 2025, 7:18 AM
F18710136: D15374.diff
Sep 29 2025, 1:29 AM
F18653976: D15374.diff
Sep 21 2025, 11:28 PM
F18627804: D15374.id37067.diff
Sep 16 2025, 4:49 AM
F18590612: D15374.id37067.diff
Sep 12 2025, 6:34 AM
F18587515: D15374.id37067.diff
Sep 11 2025, 9:38 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10485: Ponder title size look weird compared to Space title size
Commits
Restricted Diffusion Commit
rP21f8323612cb: Fix spaces UI in PHUIHeaderView
Summary

This should consistenly apply the styling regardless of font or size of the Header. Fixes T10485

Test Plan

Visit a Task and a Countdown in a different Space.

Diff Detail

Repository
rP Phabricator
Branch
phui-header (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10924
Build 13479: Run Core Tests
Build 13478: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37067.Mar 1 2016, 7:45 PM
chad retitled this revision from to Fix spaces UI in PHUIHeaderView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10485: Ponder title size look weird compared to Space title size.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2016, 7:45 PM
epriestley accepted this revision.Mar 1 2016, 7:46 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 7:46 PM
Closed by commit rP21f8323612cb: Fix spaces UI in PHUIHeaderView (authored by chad, committed by chad). · Explain WhyMar 1 2016, 7:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
phui/
8 lines
webroot/
rsrc/
css/
phui/
8 lines

Diff 37067

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility