HomePhabricator

Solidify PHUITwoColumnView as a page layout

Tags
None
Referenced Files
F1135708: Screen Shot 2016-02-29 at 1.30.09 PM.png
Mar 1 2016, 3:24 PM
F1135707: Screen Shot 2016-02-29 at 1.30.16 PM.png
Mar 1 2016, 3:24 PM
F1135709: Screen Shot 2016-02-29 at 1.29.58 PM.png
Mar 1 2016, 3:24 PM
F1135711: Screen Shot 2016-02-29 at 1.29.50 PM.png
Mar 1 2016, 3:24 PM
F1135710: Screen Shot 2016-02-29 at 1.29.55 PM.png
Mar 1 2016, 3:24 PM
F1135705: Screen Shot 2016-02-29 at 1.30.34 PM.png
Mar 1 2016, 3:24 PM
F1135706: Screen Shot 2016-02-29 at 1.30.26 PM.png
Mar 1 2016, 3:24 PM
Subscribers
None

Description

Solidify PHUITwoColumnView as a page layout

Summary:
Rolls out a new "Object Page" design with PHUITwoColumnView. This is reasonably polished, but wanted to post it up for you now for feedback before chasing down minor bugs. This implements TwoColumn in the following applications:

  • Ponder
  • Paste
  • Slowvote
  • Countdown
  • Projects
  • Profile
  • Passphrase

This helped track down display issues and inconsistencies and make sure the layout was flexible for different pages.

Test Plan:
Test each of the applications on mobile, tablet, and desktop breakpoints.

Screen Shot 2016-02-29 at 1.30.34 PM.png (1×2 px, 442 KB)

Screen Shot 2016-02-29 at 1.30.26 PM.png (1×2 px, 419 KB)

Screen Shot 2016-02-29 at 1.30.16 PM.png (1×2 px, 554 KB)

Screen Shot 2016-02-29 at 1.30.09 PM.png (1×2 px, 650 KB)

Screen Shot 2016-02-29 at 1.29.58 PM.png (1×2 px, 414 KB)

Screen Shot 2016-02-29 at 1.29.55 PM.png (1×2 px, 459 KB)

Screen Shot 2016-02-29 at 1.29.50 PM.png (1×2 px, 470 KB)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15366

Details

Auditors
chad
Provenance
chadAuthored on Feb 26 2016, 10:34 PM
epriestleyCommitted on Mar 1 2016, 3:23 PM
epriestleyPushed on Mar 1 2016, 3:24 PM
Reviewer
epriestley
Differential Revision
D15366: Solidify PHUITwoColumnView as a page layout
Parents
rP8240e0f72706: Treat "skipped" unit tests as less interesting than "passed"
Branches
Unknown
Tags
Unknown
Build Status
Buildable 10921
Build 13473: Run Core Tests