Declare tokenCache on AASTNode
ClosedPublic
Actions

Authored by epriestley on Feb 27 2016, 3:25 PM.

Details

Reviewers

joshuaspence
chad

Commits

rPHU6ef9295e388d: Declare tokenCache on AASTNode

Summary

See discussion in T10462. Because this class extends Phobject, calling $this->undeclaredProperty = $value; throws.

Declare $tokenCache.

Test Plan

Added debugging statements, saw change cause cache hits to occur.

Diff Detail

Repository

rPHU libphutil

Branch

aastcache

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10874
Build 13408: Run Core Tests
Build 13407: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37034.Feb 27 2016, 3:25 PM

epriestley retitled this revision from to Declare tokenCache on AASTNode.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, joshuaspence.

epriestley mentioned this in T10462: AASTNode in libphutil missing tokenCache declaration.Feb 27 2016, 3:27 PM

chad accepted this revision.Feb 27 2016, 3:29 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 27 2016, 3:29 PM

Closed by commit rPHU6ef9295e388d: Declare tokenCache on AASTNode (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2016, 4:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

aast/

api/

AASTNode.php

1 line

Diff 37034

View Options

src/parser/aast/api/AASTNode.php

Declare tokenCache on AASTNodeClosedPublicActions