Page MenuHomePhabricator

Declare tokenCache on AASTNode
ClosedPublic

Authored by epriestley on Feb 27 2016, 3:25 PM.
Tags
None
Referenced Files
F22669077: D15358.id37035.diff
Thu, Oct 1, 4:37 PM
F22669076: D15358.id37034.diff
Thu, Oct 1, 4:37 PM
F22669075: D15358.id.diff
Thu, Oct 1, 4:37 PM
F22662234: D15358.diff
Thu, Oct 1, 10:08 AM
F22648973: D15358.id37034.diff
Wed, Sep 30, 8:54 PM
F22608420: D15358.id37034.diff
Tue, Sep 29, 1:17 AM
F22568195: D15358.diff
Sat, Sep 26, 1:56 AM
Unknown Object (File)
Thu, Sep 17, 6:32 PM
Subscribers
None

Details

Summary

See discussion in T10462. Because this class extends Phobject, calling $this->undeclaredProperty = $value; throws.

Declare $tokenCache.

Test Plan

Added debugging statements, saw change cause cache hits to occur.

Diff Detail

Repository
rPHU libphutil
Branch
aastcache
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10874
Build 13408: Run Core Tests
Build 13407: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Declare tokenCache on AASTNode.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 27 2016, 3:29 PM
This revision was automatically updated to reflect the committed changes.