Paths

Table of Contentst

Differential D15295

Remove uncalled DiffusionRequest->getCallsign()
ClosedPublic
Actions

Authored by epriestley on Feb 18 2016, 1:15 AM.

Tags

None

Referenced Files

	F14397296: D15295.diff
	Sun, Dec 22, 10:08 AM

	F14388236: D15295.id36900.diff
	Sat, Dec 21, 3:51 PM

	Unknown Object (File)
	Wed, Dec 11, 6:46 AM

	Unknown Object (File)
	Sat, Dec 7, 2:21 PM

	Unknown Object (File)
	Fri, Dec 6, 11:52 AM

	Unknown Object (File)
	Fri, Nov 29, 10:04 AM

	Unknown Object (File)
	Thu, Nov 28, 1:01 PM

	Unknown Object (File)
	Sun, Nov 24, 12:44 AM

Subscribers

None

Details

Reviewers

avivey
chad

Maniphest Tasks

T4245: Make repository URIs slightly prettier

Commits

Restricted Diffusion Commit
rP93d7b0122252: Remove uncalled DiffusionRequest->getCallsign()

Summary

Ref T4245. This has no callers.

Test Plan

Ran git grep -i 'getCallsign(' and visually verified that no callers could reasonably be DiffusionRequest objects (there are only 23 remaining sites, and about half are $this->... in PhabricatorRepository.
Browsed around directory/file/branch/content/diff/etc pages in Diffusion.

Diff Detail

Repository

Branch

call3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10742
Build 13215: Run Core Tests
Build 13214: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36899.Feb 18 2016, 1:15 AM

epriestley retitled this revision from to Remove uncalled DiffusionRequest->getCallsign().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, avivey.

epriestley added a task: T4245: Make repository URIs slightly prettier.

avivey accepted this revision.Feb 18 2016, 1:17 AM

avivey edited edge metadata.

This revision is now accepted and ready to land.Feb 18 2016, 1:17 AM

Closed by commit rP93d7b0122252: Remove uncalled DiffusionRequest->getCallsign() (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2016, 1:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

request/

DiffusionRequest.php

4 lines

Diff 36899

src/applications/diffusion/request/DiffusionRequest.php

Loading...