Paths

Table of Contentst

Differential D15295

Remove uncalled DiffusionRequest->getCallsign()
ClosedPublic
Actions

Authored by epriestley on Feb 18 2016, 1:15 AM.

Tags

None

Referenced Files

	F18737898: D15295.diff
	Wed, Oct 1, 1:12 PM

	F18699367: D15295.id36899.diff
	Sat, Sep 27, 12:46 PM

	F18606435: D15295.id36900.diff
	Sat, Sep 13, 10:19 PM

	F18195457: D15295.diff
	Aug 17 2025, 3:53 PM

	F18085791: D15295.id.diff
	Aug 5 2025, 7:25 PM

	F18051659: D15295.id36899.diff
	Aug 3 2025, 11:59 PM

	F18051463: D15295.id36900.diff
	Aug 3 2025, 11:23 PM

	Unknown Object (File)
	Jun 18 2025, 3:19 AM

Subscribers

None

Details

Reviewers

avivey
chad

Maniphest Tasks

T4245: Make repository URIs slightly prettier

Commits

Restricted Diffusion Commit
rP93d7b0122252: Remove uncalled DiffusionRequest->getCallsign()

Summary

Ref T4245. This has no callers.

Test Plan

Ran git grep -i 'getCallsign(' and visually verified that no callers could reasonably be DiffusionRequest objects (there are only 23 remaining sites, and about half are $this->... in PhabricatorRepository.
Browsed around directory/file/branch/content/diff/etc pages in Diffusion.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36899.Feb 18 2016, 1:15 AM

epriestley retitled this revision from to Remove uncalled DiffusionRequest->getCallsign().

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, avivey.

epriestley added a task: T4245: Make repository URIs slightly prettier.

avivey accepted this revision.Feb 18 2016, 1:17 AM

avivey edited edge metadata.

This revision is now accepted and ready to land.Feb 18 2016, 1:17 AM

Closed by commit rP93d7b0122252: Remove uncalled DiffusionRequest->getCallsign() (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2016, 1:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

request/

DiffusionRequest.php

4 lines

Diff 36900

src/applications/diffusion/request/DiffusionRequest.php

Loading...