Page MenuHomePhabricator

Fix method call on possible null
ClosedPublic

Authored by epriestley on Feb 10 2016, 8:36 PM.
Tags
None
Referenced Files
F13215156: D15235.id36767.diff
Fri, May 17, 3:24 PM
F13191057: D15235.id.diff
Sat, May 11, 4:51 PM
F13177448: D15235.diff
Wed, May 8, 7:43 PM
F13176402: D15235.diff
Wed, May 8, 1:36 PM
Unknown Object (File)
Mon, Apr 29, 3:00 PM
Unknown Object (File)
Wed, Apr 24, 10:56 PM
Unknown Object (File)
Apr 19 2024, 4:11 PM
Unknown Object (File)
Apr 16 2024, 5:24 PM
Subscribers
None

Details

Summary

Fixes T10317. If we failed to load $device, it will be null, so we won't be able to call getName() on it.

Test Plan

SSH_CLIENT='127.0.0.1' ./bin/ssh-exec --phabricator-ssh-device xyz no longer fatals

Diff Detail

Repository
rP Phabricator
Branch
device1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10609
Build 13017: Run Core Tests
Build 13016: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix method call on possible null.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 10 2016, 8:36 PM
This revision was automatically updated to reflect the committed changes.