Paths

Table of Contentst

Fix method call on possible null
ClosedPublic
Actions

Authored by epriestley on Feb 10 2016, 8:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 25, 10:10 PM

	Unknown Object (File)
	Mon, Dec 23, 8:06 AM

	Unknown Object (File)
	Wed, Dec 18, 1:08 AM

	Unknown Object (File)
	Wed, Dec 18, 1:08 AM

	Unknown Object (File)
	Wed, Dec 18, 1:08 AM

	Unknown Object (File)
	Wed, Dec 18, 1:07 AM

	Unknown Object (File)
	Tue, Dec 17, 10:42 AM

	Unknown Object (File)
	Mon, Dec 16, 6:25 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10317: ssh-exec.php: possible null pointer dereference

Commits

Restricted Diffusion Commit
rP3f920d890474: Fix method call on possible null

Summary

Fixes T10317. If we failed to load $device, it will be null, so we won't be able to call getName() on it.

Test Plan

SSH_CLIENT='127.0.0.1' ./bin/ssh-exec --phabricator-ssh-device xyz no longer fatals

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36767.Feb 10 2016, 8:36 PM

epriestley retitled this revision from to Fix method call on possible null.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10317: ssh-exec.php: possible null pointer dereference.

chad accepted this revision.Feb 10 2016, 8:36 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 10 2016, 8:36 PM

Closed by commit rP3f920d890474: Fix method call on possible null (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2016, 8:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

ssh/

ssh-exec.php

2 lines

Diff 36768

View Options

Fix method call on possible nullClosedPublicActions