Page MenuHomePhabricator

ssh-exec.php: possible null pointer dereference
Closed, ResolvedPublic

Description

We check your project https://github.com/phacility/phabricator/ with static analyzer AppChecker, it found possible problem in code:

File scripts/ssh/ssh-exec.php, line 132 (https://github.com/phacility/phabricator/blob/aa6c993848797d792a886b4a570f20ca897ade7e/scripts/ssh/ssh-exec.php#L132)

if (!$device) {
    throw new Exception(
      pht(
        'Invalid device name ("%s"). There is no device with this name.',
        $device->getName()));
 }

Probably it should be:

if (!$device) {
    throw new Exception(
      pht(
        'Invalid device name ("%s"). There is no device with this name.',
         $device_name));
 }

Hope this will help you

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley added a revision: Restricted Differential Revision.Feb 10 2016, 8:36 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Feb 10 2016, 8:44 PM
epriestley added a commit: Restricted Diffusion Commit.