Page MenuHomePhabricator

Disambiguate isEmpty()
ClosedPublic

Authored by epriestley on Jan 31 2016, 11:18 PM.
Tags
None
Referenced Files
F19212289: D15151.diff
Wed, Dec 17, 2:58 AM
F19094979: D15151.diff
Dec 4 2025, 3:39 AM
F19094978: D15151.diff
Dec 4 2025, 3:39 AM
F18808226: D15151.id.diff
Oct 19 2025, 5:36 AM
F18764855: D15151.id36581.diff
Oct 7 2025, 8:14 AM
F18753972: D15151.id36582.diff
Oct 4 2025, 8:55 PM
F18737897: D15151.diff
Oct 1 2025, 1:12 PM
F18625584: D15151.diff
Sep 15 2025, 11:05 PM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10250: FATAL ERROR - AphrontTagView
Commits
Restricted Diffusion Commit
rP354858e43406: Disambiguate isEmpty()
Summary

Fixes T10250.

Rename the one I added to hasAnyProperties() for clarity.

Test Plan
  • Viewed a project profile with content.
  • Viewed a project profile with no properties.
  • Viewed a workboard with tasks that had a mixture of additional projects and no additional projects.

Diff Detail

Repository
rP Phabricator
Branch
isempty
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10423
Build 12734: Run Core Tests
Build 12733: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Disambiguate isEmpty().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2016, 11:19 PM
This revision was automatically updated to reflect the committed changes.