Page MenuHomePhabricator
Differential D15151

Disambiguate isEmpty()
ClosedPublic
Actions

Authored by epriestley on Jan 31 2016, 11:18 PM.
Tags
None
Referenced Files
F15505641: D15151.diff
Tue, Apr 15, 4:38 AM
F15503592: D15151.id36581.diff
Mon, Apr 14, 11:09 AM
F15479125: D15151.diff
Tue, Apr 8, 5:10 AM
F15479110: D15151.id.diff
Tue, Apr 8, 5:10 AM
F15479072: D15151.id36581.diff
Tue, Apr 8, 5:07 AM
F15479066: D15151.id36582.diff
Tue, Apr 8, 5:07 AM
F15453382: D15151.id.diff
Sat, Mar 29, 11:23 AM
F15453297: D15151.id36581.diff
Sat, Mar 29, 10:45 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10250: FATAL ERROR - AphrontTagView
Commits
Restricted Diffusion Commit
rP354858e43406: Disambiguate isEmpty()
Summary

Fixes T10250.

Rename the one I added to hasAnyProperties() for clarity.

Test Plan
  • Viewed a project profile with content.
  • Viewed a project profile with no properties.
  • Viewed a workboard with tasks that had a mixture of additional projects and no additional projects.

Diff Detail

Repository
rP Phabricator
Branch
isempty
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10423
Build 12734: Run Core Tests
Build 12733: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36581.Jan 31 2016, 11:18 PM
epriestley retitled this revision from to Disambiguate isEmpty().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10250: FATAL ERROR - AphrontTagView.
chad accepted this revision.Jan 31 2016, 11:19 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2016, 11:19 PM
Closed by commit rP354858e43406: Disambiguate isEmpty() (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2016, 11:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
2 lines
project/
controller/
2 lines
view/
11 lines
view/
4 lines
phui/
6 lines

Diff 36581

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/project/view/ProjectBoardTaskCard.php

Loading...
View Options

src/view/AphrontTagView.php

Loading...
View Options

src/view/phui/PHUIPropertyListView.php

Loading...
Phabricator · Built by Phacility