Page MenuHomePhabricator
Differential D15151

Disambiguate isEmpty()
ClosedPublic
Actions

Authored by epriestley on Jan 31 2016, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 4:06 AM
Unknown Object (File)
Wed, Nov 27, 8:30 PM
Unknown Object (File)
Wed, Nov 27, 3:33 PM
Unknown Object (File)
Thu, Nov 21, 10:41 PM
Unknown Object (File)
Nov 21 2024, 3:25 PM
Unknown Object (File)
Nov 18 2024, 8:38 PM
Unknown Object (File)
Nov 12 2024, 7:12 AM
Unknown Object (File)
Nov 11 2024, 10:13 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10250: FATAL ERROR - AphrontTagView
Commits
Restricted Diffusion Commit
rP354858e43406: Disambiguate isEmpty()
Summary

Fixes T10250.

Rename the one I added to hasAnyProperties() for clarity.

Test Plan
  • Viewed a project profile with content.
  • Viewed a project profile with no properties.
  • Viewed a workboard with tasks that had a mixture of additional projects and no additional projects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36581.Jan 31 2016, 11:18 PM
epriestley retitled this revision from to Disambiguate isEmpty().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10250: FATAL ERROR - AphrontTagView.
chad accepted this revision.Jan 31 2016, 11:19 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2016, 11:19 PM
Closed by commit rP354858e43406: Disambiguate isEmpty() (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2016, 11:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
2 lines
project/
controller/
2 lines
view/
11 lines
view/
4 lines
phui/
6 lines

Diff 36582

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/project/view/ProjectBoardTaskCard.php

Loading...
View Options

src/view/AphrontTagView.php

Loading...
View Options

src/view/phui/PHUIPropertyListView.php

Loading...
Phabricator · Built by Phacility