Page MenuHomePhabricator

Disambiguate isEmpty()
ClosedPublic

Authored by epriestley on Jan 31 2016, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 4:06 AM
Unknown Object (File)
Wed, Nov 27, 8:30 PM
Unknown Object (File)
Wed, Nov 27, 3:33 PM
Unknown Object (File)
Thu, Nov 21, 10:41 PM
Unknown Object (File)
Nov 21 2024, 3:25 PM
Unknown Object (File)
Nov 18 2024, 8:38 PM
Unknown Object (File)
Nov 12 2024, 7:12 AM
Unknown Object (File)
Nov 11 2024, 10:13 PM
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10250: FATAL ERROR - AphrontTagView
Commits
Restricted Diffusion Commit
rP354858e43406: Disambiguate isEmpty()
Summary

Fixes T10250.

Rename the one I added to hasAnyProperties() for clarity.

Test Plan
  • Viewed a project profile with content.
  • Viewed a project profile with no properties.
  • Viewed a workboard with tasks that had a mixture of additional projects and no additional projects.

Diff Detail

Repository
rP Phabricator
Branch
isempty
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10423
Build 12734: Run Core Tests
Build 12733: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Disambiguate isEmpty().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2016, 11:19 PM
This revision was automatically updated to reflect the committed changes.