Differential D15063

Allow any user to watch any project they can see
ClosedPublic
Actions

Authored by epriestley on Jan 20 2016, 1:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 9:40 AM

	Unknown Object (File)
	Thu, Dec 19, 12:57 AM

	Unknown Object (File)
	Wed, Dec 18, 4:29 PM

	Unknown Object (File)
	Tue, Dec 17, 10:08 PM

	Unknown Object (File)
	Fri, Dec 13, 12:43 AM

	Unknown Object (File)
	Sat, Dec 7, 8:52 PM

	Unknown Object (File)
	Tue, Nov 26, 11:20 PM

	Unknown Object (File)
	Tue, Nov 26, 9:50 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T6183: Allow any user to watch projects
T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP5c2e49a81223: Allow any user to watch any project they can see

Summary

Ref T6183. Ref T10054. Historically, only members could watch projects because there were some weird special cases with policies. These policy issues have been resolved and Herald is generally powerful enough to do equivalent watches on most objects anyway.

Also puts a "Watch Project" button on the feed panel to make the behavior and meaning more obvious.

Test Plan

Watched a project I was not a member of.
Clicked the feed watch/unwatch button.

Screen Shot 2016-01-19 at 5.52.07 PM.png (349×897 px, 44 KB)

Diff Detail

Repository

Branch

pmenu9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10208
Build 12406: Run Core Tests
Build 12405: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36372.Jan 20 2016, 1:55 AM

epriestley retitled this revision from to Allow any user to watch any project they can see.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10054: Define product direction for Project/Profile UIs, T6183: Allow any user to watch projects.

chad accepted this revision.Jan 20 2016, 1:55 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 20 2016, 1:55 AM

Also allow any user to subscribe to any project they can see.
Remove weird rules around removing watches when leaving projects.

Closed by commit rP5c2e49a81223: Allow any user to watch any project they can see (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2016, 3:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

storage/

PhabricatorBadgesBadge.php

4 lines

calendar/

storage/

PhabricatorCalendarEvent.php

4 lines

countdown/

storage/

PhabricatorCountdown.php

4 lines

differential/

storage/

DifferentialRevision.php

4 lines

files/

storage/

PhabricatorFile.php

4 lines

fund/

storage/

FundInitiative.php

4 lines

harbormaster/

storage/

configuration/

HarbormasterBuildPlan.php

4 lines

herald/

storage/

4 lines

legalpad/

storage/

LegalpadDocument.php

4 lines

macro/

storage/

PhabricatorFileImageMacro.php

4 lines

maniphest/

storage/

ManiphestTask.php

4 lines

passphrase/

storage/

PassphraseCredential.php

4 lines

paste/

storage/

PhabricatorPaste.php

4 lines

phame/

storage/

4 lines

4 lines

pholio/

storage/

4 lines

phriction/

storage/

PhrictionDocument.php

4 lines

phurl/

storage/

PhabricatorPhurlURL.php

4 lines

ponder/

storage/

PonderAnswer.php

4 lines

PonderQuestion.php

4 lines

project/

controller/

PhabricatorProjectMembersViewController.php

30 lines

PhabricatorProjectProfileController.php

37 lines

PhabricatorProjectWatchController.php

15 lines

editor/

PhabricatorProjectTransactionEditor.php

34 lines

storage/

PhabricatorProject.php

5 lines

view/

PhabricatorProjectUserListView.php

24 lines

repository/

storage/

PhabricatorRepositoryCommit.php

4 lines

slowvote/

storage/

PhabricatorSlowvotePoll.php

4 lines

subscriptions/

controller/

PhabricatorSubscriptionsEditController.php

7 lines

events/

PhabricatorSubscriptionsUIEventListener.php

5 lines

interface/

PhabricatorSubscribableInterface.php

15 lines

infrastructure/

daemon/

workers/

storage/

PhabricatorWorkerBulkJob.php

4 lines

Diff 36373

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/countdown/storage/PhabricatorCountdown.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/applications/fund/storage/FundInitiative.php

Loading...

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

Loading...

src/applications/herald/storage/HeraldRule.php

Loading...

src/applications/legalpad/storage/LegalpadDocument.php

Loading...

src/applications/macro/storage/PhabricatorFileImageMacro.php

Loading...

src/applications/maniphest/storage/ManiphestTask.php

Loading...

src/applications/passphrase/storage/PassphraseCredential.php

Loading...

src/applications/paste/storage/PhabricatorPaste.php

Loading...

src/applications/phame/storage/PhameBlog.php

Loading...

src/applications/phame/storage/PhamePost.php

Loading...

src/applications/pholio/storage/PholioMock.php

Loading...

src/applications/phriction/storage/PhrictionDocument.php

Loading...

src/applications/phurl/storage/PhabricatorPhurlURL.php

Loading...

src/applications/ponder/storage/PonderAnswer.php

Loading...

src/applications/ponder/storage/PonderQuestion.php

Loading...

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...

src/applications/project/controller/PhabricatorProjectWatchController.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...

src/applications/project/view/PhabricatorProjectUserListView.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

Loading...

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

Loading...

src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php

Loading...

src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php

Loading...