Page MenuHomePhabricator

Allow any user to watch any project they can see

Authored by epriestley on Jan 20 2016, 1:55 AM.



Ref T6183. Ref T10054. Historically, only members could watch projects because there were some weird special cases with policies. These policy issues have been resolved and Herald is generally powerful enough to do equivalent watches on most objects anyway.

Also puts a "Watch Project" button on the feed panel to make the behavior and meaning more obvious.

Test Plan
  • Watched a project I was not a member of.
  • Clicked the feed watch/unwatch button.

Screen Shot 2016-01-19 at 5.52.07 PM.png (349×897 px, 44 KB)

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 10208
Build 12406: Run Core Tests
Build 12405: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow any user to watch any project they can see.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 20 2016, 1:55 AM
epriestley edited edge metadata.
  • Also allow any user to subscribe to any project they can see.
  • Remove weird rules around removing watches when leaving projects.
This revision was automatically updated to reflect the committed changes.