Page MenuHomePhabricator

Allow any user to watch any project they can see
ClosedPublic

Authored by epriestley on Jan 20 2016, 1:55 AM.
Tags
None
Referenced Files
F14427650: D15063.id36372.diff
Wed, Dec 25, 2:05 PM
Unknown Object (File)
Tue, Dec 24, 7:03 PM
Unknown Object (File)
Mon, Dec 23, 6:19 AM
Unknown Object (File)
Thu, Dec 19, 9:40 AM
Unknown Object (File)
Thu, Dec 19, 12:57 AM
Unknown Object (File)
Wed, Dec 18, 4:29 PM
Unknown Object (File)
Tue, Dec 17, 10:08 PM
Unknown Object (File)
Fri, Dec 13, 12:43 AM
Subscribers
None

Details

Summary

Ref T6183. Ref T10054. Historically, only members could watch projects because there were some weird special cases with policies. These policy issues have been resolved and Herald is generally powerful enough to do equivalent watches on most objects anyway.

Also puts a "Watch Project" button on the feed panel to make the behavior and meaning more obvious.

Test Plan
  • Watched a project I was not a member of.
  • Clicked the feed watch/unwatch button.

Screen Shot 2016-01-19 at 5.52.07 PM.png (349×897 px, 44 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow any user to watch any project they can see.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 20 2016, 1:55 AM
epriestley edited edge metadata.
  • Also allow any user to subscribe to any project they can see.
  • Remove weird rules around removing watches when leaving projects.
This revision was automatically updated to reflect the committed changes.