Differential D15063

Allow any user to watch any project they can see
ClosedPublic
Actions

Authored by epriestley on Jan 20 2016, 1:55 AM.

Tags

None

Referenced Files

	F14351699: D15063.diff
	Thu, Dec 19, 9:40 AM

	F14345004: D15063.id36372.diff
	Thu, Dec 19, 12:57 AM

	F14332681: D15063.id36372.diff
	Wed, Dec 18, 4:29 PM

	Unknown Object (File)
	Tue, Dec 17, 10:08 PM

	Unknown Object (File)
	Fri, Dec 13, 12:43 AM

	Unknown Object (File)
	Sat, Dec 7, 8:52 PM

	Unknown Object (File)
	Tue, Nov 26, 11:20 PM

	Unknown Object (File)
	Tue, Nov 26, 9:50 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T6183: Allow any user to watch projects
T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP5c2e49a81223: Allow any user to watch any project they can see

Summary

Ref T6183. Ref T10054. Historically, only members could watch projects because there were some weird special cases with policies. These policy issues have been resolved and Herald is generally powerful enough to do equivalent watches on most objects anyway.

Also puts a "Watch Project" button on the feed panel to make the behavior and meaning more obvious.

Test Plan

Watched a project I was not a member of.
Clicked the feed watch/unwatch button.

Screen Shot 2016-01-19 at 5.52.07 PM.png (349×897 px, 44 KB)

Diff Detail

Repository

Branch

pmenu9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10207
Build 12404: Run Core Tests
Build 12403: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36372.Jan 20 2016, 1:55 AM

epriestley retitled this revision from to Allow any user to watch any project they can see.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10054: Define product direction for Project/Profile UIs, T6183: Allow any user to watch projects.

chad accepted this revision.Jan 20 2016, 1:55 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 20 2016, 1:55 AM

Also allow any user to subscribe to any project they can see.
Remove weird rules around removing watches when leaving projects.

Closed by commit rP5c2e49a81223: Allow any user to watch any project they can see (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2016, 3:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectMembersViewController.php

30 lines

PhabricatorProjectProfileController.php

37 lines

PhabricatorProjectWatchController.php

15 lines

view/

PhabricatorProjectUserListView.php

24 lines

Diff 36372

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...

src/applications/project/controller/PhabricatorProjectWatchController.php

Loading...

src/applications/project/view/PhabricatorProjectUserListView.php

Loading...