Add Herald support for projects
ClosedPublic
Actions

Authored by epriestley on Jan 20 2016, 1:23 AM.

Details

Reviewers

Maniphest Tasks

T6113: Unclear difference between "Watch Project" and "Subscribe"
T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rPa8dd74d292eb: Add Herald support for projects

Summary

Ref T10054. Ref T6113. I'm going to remove subscribers from projects to fix the confusion between "watch" and "subscribe".

Users who have unusual use cases where they legitimately want to know when a project's description is updated or members change can use Herald to follow it.

This is also useful in general and improves consistency, although I don't have too many use cases for it.

Test Plan

Wrote a Herald rule, edited a project, saw the rule fire and send me email about the change.

Diff Detail

Repository

rP Phabricator

Branch

pmenu7

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10205
Build 12400: Run Core Tests
Build 12399: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36370.Jan 20 2016, 1:23 AM

epriestley retitled this revision from to Add Herald support for projects.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10054: Define product direction for Project/Profile UIs, T6113: Unclear difference between "Watch Project" and "Subscribe".

Herald edited edge metadata. · View Herald TranscriptJan 20 2016, 1:23 AM

chad accepted this revision.Jan 20 2016, 1:42 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 20 2016, 1:42 AM

Oh, actually, I can't just remove subscribers because they still control whether you're part of the recipients when a project is subscribed or used as a reviewer or auditor. That's also not the same as watching.

I may replace that with a more obvious, dedicated "Send me mail which is sent to this project" option or something eventually. I'll probably just leave it as-is and document it for now.

epriestley mentioned this in D15065: Replace subscribe/unsubscribe for projects with explicit mail setting.Jan 20 2016, 3:11 AM

Closed by commit rPa8dd74d292eb: Add Herald support for projects (authored by epriestley, committed by epriestley). · Explain WhyJan 20 2016, 3:37 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP8463ad265960: Replace subscribe/unsubscribe for projects with explicit mail setting.