Page MenuHomePhabricator
Differential D15044

Distinguish between "no coverage information" and "no test coverage" better
ClosedPublic
Actions

Authored by epriestley on Jan 18 2016, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 6:27 PM
Unknown Object (File)
Tue, Apr 30, 11:16 PM
Unknown Object (File)
Sat, Apr 27, 10:29 AM
Unknown Object (File)
Sun, Apr 21, 6:17 AM
Unknown Object (File)
Thu, Apr 18, 8:48 AM
Unknown Object (File)
Wed, Apr 17, 2:30 PM
Unknown Object (File)
Apr 12 2024, 7:25 PM
Unknown Object (File)
Apr 11 2024, 6:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10169: Differential Revision without coverage shows all code as "Non Executable"
Commits
Restricted Diffusion Commit
rP45a4a68628b9: Distinguish between "no coverage information" and "no test coverage" better
Summary

Fixes T10169. Diffs with no build targets were incorrectly showing as though they had no test coverage, when we actually want to show them having no coverage information available.

Test Plan

Viewed an older revision, saw a column of "Not Executable" before change, now see no column.

Diff Detail

Repository
rP Phabricator
Branch
cov1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10167
Build 12341: Run Core Tests
Build 12340: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36332.Jan 18 2016, 3:11 PM
epriestley retitled this revision from to Distinguish between "no coverage information" and "no test coverage" better.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10169: Differential Revision without coverage shows all code as "Non Executable".
chad accepted this revision.Jan 18 2016, 3:50 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 18 2016, 3:50 PM
Closed by commit rP45a4a68628b9: Distinguish between "no coverage information" and "no test coverage" better (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2016, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
15 lines

Diff 36332

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
Phabricator · Built by Phacility