Page MenuHomePhabricator

Differential Revision without coverage shows all code as "Non Executable"
Closed, ResolvedPublic

Description

Right now each Diff of Differential Revision has associated Harbormaster Build that holds lint/unit test results. Diffs created before this Phabricator code change was introduced are shown as having 100% of code non-covered:

Phabricator_DiffWithoutBuildShownAsNonExecutable.png (305×737 px, 79 KB)

This happens before for case, when Harbormaster Build was not found (see https://secure.phabricator.com/diffusion/P/browse/master/src/applications/differential/controller/DifferentialChangesetViewController.php;7ab970d1a7d347d2d318f9cedbe11ac75addfa3a$403) the coverage is array() (0% coverage) instead of null (no coverage information provided).

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley triaged this task as Wishlist priority.Jan 17 2016, 3:52 PM
epriestley added a revision: Restricted Differential Revision.Jan 18 2016, 3:11 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 18 2016, 4:34 PM
epriestley added a commit: Restricted Diffusion Commit.