Page MenuHomePhabricator
Differential D14860

Don't throw `PhutilMissingSymbolException` from within `method_exists` and `property_exists` calls
ClosedPublic
Actions

Authored by joshuaspence on Dec 23 2015, 12:36 PM.
Tags
None
Referenced Files
F15592736: D14860.id.diff
Sat, May 10, 6:22 AM
F15578868: D14860.id35925.diff
Tue, May 6, 9:23 PM
F15561019: D14860.diff
Tue, Apr 29, 5:44 PM
F15437893: D14860.id.diff
Mar 25 2025, 10:00 PM
F15434562: D14860.id35925.diff
Mar 25 2025, 4:25 AM
F15434518: D14860.id35926.diff
Mar 25 2025, 4:14 AM
F15424448: D14860.diff
Mar 22 2025, 10:28 PM
F15424197: D14860.id35925.diff
Mar 22 2025, 8:48 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function
T9954: Cannot change a fulfiled promise to rejected
Commits
rPHUa654742b2100: (stable) Promote 2015 Week 52
rPHU14765d36f83a: Don't throw `PhutilMissingSymbolException` from within `method_exists` and…
Summary

Ref T1116. Fixes T9954. It seems that method_exists and propery_exists can trigger PHP autoloaders as well.

Test Plan

Fixed the issue described in T9954.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9745
Build 11701: Run Core Tests
Build 11700: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35925.Dec 23 2015, 12:36 PM
joshuaspence retitled this revision from to Don't throw `PhutilMissingSymbolException` from within `method_exists` and `property_exists` calls.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added tasks: T9954: Cannot change a fulfiled promise to rejected, T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 23 2015, 12:36 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 23 2015, 12:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 12:50 PM
joshuaspence updated this revision to Diff 35926.Dec 23 2015, 12:55 PM
joshuaspence edited edge metadata.

Fix a typo

Closed by commit rPHU14765d36f83a: Don't throw `PhutilMissingSymbolException` from within `method_exists` and… (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 23 2015, 12:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 35926

View Options

src/__phutil_library_init__.php

Loading...
Phabricator · Built by Phacility