Differential D14853

Don't show self-subscribes in feed or mail
ClosedPublic
Actions

Authored by epriestley on Dec 22 2015, 6:27 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP536d3a218530: Don't show self-subscribes in feed or mail

Summary

These transactions (when a user subscribes or unsubscribes only themselves) are universally uninteresting.

Test Plan

Subscribed/unsubscribed, saw transactions but no feed/mail.
Commented, got implicitly subscribed, saw only comment in feed/mail, saw both transasctions on task.

Diff Detail

Repository

rP Phabricator

Branch

hideself1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9726
Build 11672: Run Core Tests
Build 11671: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35907.Dec 22 2015, 6:27 PM

epriestley retitled this revision from to Don't show self-subscribes in feed or mail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Dec 22 2015, 6:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 22 2015, 6:45 PM

Closed by commit rP536d3a218530: Don't show self-subscribes in feed or mail (authored by epriestley, committed by epriestley). · Explain WhyDec 22 2015, 6:45 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10089: Unsubscribing from a Project seems to have no effect.Jan 6 2016, 2:30 AM

yelirekim awarded a token.Jan 6 2016, 5:42 AM

epriestley mentioned this in T10519: no email sent for inline comments on a Diffusion commit.Mar 5 2016, 9:57 PM

epriestley mentioned this in T8800: Inline comments on a diff cause subscribe event instead of comment event.Jan 1 2017, 5:19 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

66 lines

Diff 35907

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Don't show self-subscribes in feed or mailClosedPublicActions