Add proper PHIDs to RefCursors
ClosedPublic
Actions

Authored by epriestley on Dec 10 2015, 9:08 PM.

Details

Reviewers

chad

Maniphest Tasks

T9952: Let "Land Revision" target branches other than master

Commits

Restricted Diffusion Commit
rP2a203fbab1ff: Add proper PHIDs to RefCursors

Summary

Ref T9952. See discussion there. This change is primarily aimed at letting me build a typeahead of branches in a repository so that we can land to arbitrary branches a few diffs from now.

Test Plan

Ran migrations.
Verified database populated properly with PHIDs (SELECT * FROM repository_refcursor;).
Ran bin/repository update.
Viewed a Git repository in Diffusion.

Diff Detail

Repository

rP Phabricator

Branch

land1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9444
Build 11249: Run Core Tests
Build 11248: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35624.Dec 10 2015, 9:08 PM

epriestley retitled this revision from to Add proper PHIDs to RefCursors.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9952: Let "Land Revision" target branches other than master.

epriestley added inline comments.Dec 10 2015, 9:08 PM

src/applications/repository/storage/PhabricatorRepositoryRefCursor.php
35–37	This was intentionally nullable, `null` means "we don't know the encoding". I just didn't remember this when I was doing the `storage adjust` stuff.