Page MenuHomePhabricator

Partially support CustomFields in EditEngine
ClosedPublic

Authored by epriestley on Nov 30 2015, 10:25 PM.
Tags
None
Referenced Files
F13166980: D14617.diff
Tue, May 7, 6:41 AM
Unknown Object (File)
Fri, May 3, 4:24 AM
Unknown Object (File)
Fri, May 3, 4:24 AM
Unknown Object (File)
Fri, May 3, 1:22 AM
Unknown Object (File)
Thu, May 2, 2:59 AM
Unknown Object (File)
Mon, Apr 29, 4:08 PM
Unknown Object (File)
Wed, Apr 24, 11:58 PM
Unknown Object (File)
Wed, Apr 17, 2:36 PM
Subscribers

Details

Summary

Ref T9132. This isn't perfect, but doesn't break any existing functionality. This stuff works:

  • Editing values.
  • Reordering fields.
  • All builtin field tyepes.

This stuff may not work yet:

  • Assigning custom field defaults.
  • Some conduit stuff.
  • Fully custom fields?
  • Locking/hiding fields? Didn't actually test this one.

I'll keep chipping away at that stuff. In some cases, it may be easier to convert all the CustomField apps first, although Differential might be a fair bit of work.

Test Plan

Created a bunch of custom fields of every avialable type and edited them.

Screen Shot 2015-11-30 at 2.21.41 PM.png (1×1 px, 189 KB)

Diff Detail

Repository
rP Phabricator
Branch
ee26
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/customfield/editor/PhabricatorCustomFieldEditType.php:18XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 9170
Build 10836: Run Core Tests
Build 10835: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Partially support CustomFields in EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2015, 12:39 AM
epriestley edited edge metadata.
  • Don't show misleading parameters in parameter prefilling view.
  • Don't show misleading parameters in Conduit.
  • Fix an issue with "Required" fields.
This revision was automatically updated to reflect the committed changes.
vrana added inline comments.
src/infrastructure/customfield/field/PhabricatorCustomField.php
1086

newStandardEditField doesn't accept any parameters.