Page MenuHomePhabricator

Modernize Herald
ClosedPublic

Authored by chad on Nov 29 2015, 1:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 6:21 PM
Unknown Object (File)
Thu, Apr 11, 9:24 AM
Unknown Object (File)
Fri, Apr 5, 8:34 PM
Unknown Object (File)
Fri, Apr 5, 5:43 PM
Unknown Object (File)
Mar 17 2024, 11:31 PM
Unknown Object (File)
Mar 5 2024, 4:06 AM
Unknown Object (File)
Mar 5 2024, 4:06 AM
Unknown Object (File)
Mar 5 2024, 4:06 AM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
Restricted Diffusion Commit
rP1bfddccf3925: Modernize Herald
Summary

Updates Herald to use modern methods.

Test Plan

View List, View Test Console, Run a test, View Results, View Rules, New Rule, Edit Rule, Check mobile menus.

Diff Detail

Repository
rP Phabricator
Branch
newpage-herald
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9117
Build 10749: Run Core Tests
Build 10748: arc lint + arc unit

Event Timeline

chad retitled this revision from to Modernize Herald.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.