Page MenuHomePhabricator

Modernize Herald
ClosedPublic

Authored by chad on Nov 29 2015, 1:07 AM.
Tags
None
Referenced Files
F19541657: D14596.id35306.diff
Thu, Jan 22, 6:07 AM
F19075328: D14596.diff
Dec 1 2025, 9:26 AM
F18937999: D14596.diff
Nov 11 2025, 1:42 AM
F18852519: D14596.diff
Oct 31 2025, 9:41 AM
F18788134: D14596.id.diff
Oct 15 2025, 3:01 AM
F18761908: D14596.id35306.diff
Oct 6 2025, 4:47 PM
F18736328: D14596.id.diff
Oct 1 2025, 5:28 AM
F18728246: D14596.diff
Sep 30 2025, 9:13 AM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
Restricted Diffusion Commit
rP1bfddccf3925: Modernize Herald
Summary

Updates Herald to use modern methods.

Test Plan

View List, View Test Console, Run a test, View Results, View Rules, New Rule, Edit Rule, Check mobile menus.

Diff Detail

Repository
rP Phabricator
Branch
newpage-herald
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9117
Build 10749: Run Core Tests
Build 10748: arc lint + arc unit

Event Timeline

chad retitled this revision from to Modernize Herald.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.