Page MenuHomePhabricator

Modernize Herald
ClosedPublic

Authored by chad on Nov 29 2015, 1:07 AM.
Tags
None
Referenced Files
F15456694: D14596.diff
Sun, Mar 30, 11:28 AM
F15421549: D14596.id35306.diff
Sat, Mar 22, 12:44 AM
F15420941: D14596.id35331.diff
Fri, Mar 21, 7:17 PM
F15396464: D14596.id35331.diff
Sun, Mar 16, 2:30 PM
F15395900: D14596.diff
Sun, Mar 16, 10:35 AM
F15367955: D14596.id35306.diff
Tue, Mar 11, 10:36 PM
F15304220: D14596.diff
Mar 6 2025, 1:30 AM
Unknown Object (File)
Feb 27 2025, 1:17 AM
Subscribers

Details

Reviewers
epriestley
Maniphest Tasks
T9690: Remove calls to methods deprecated by newPage()
Commits
Restricted Diffusion Commit
rP1bfddccf3925: Modernize Herald
Summary

Updates Herald to use modern methods.

Test Plan

View List, View Test Console, Run a test, View Results, View Rules, New Rule, Edit Rule, Check mobile menus.

Diff Detail

Repository
rP Phabricator
Branch
newpage-herald
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9117
Build 10749: Run Core Tests
Build 10748: arc lint + arc unit

Event Timeline

chad retitled this revision from to Modernize Herald.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2015, 4:45 PM
This revision was automatically updated to reflect the committed changes.