A user reported to me that arc lint was failing with an error message along the lines of "argument 1 passed to idx must be of type array, bool given". I suspect that the user is running an older version of PHP, which means that array_combine(array(), array()) is returning false instead of the expected array(). Instead, avoid calling array_combine on an empty array.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC28f5b0ddc6bb: Fix a compatibility issue with `ArcanistUnsafeDynamicStringXHPASTLinterRule`
I don't have PHP 5.3 easily accessible to test this.
Diff Detail
Diff Detail
- Branch
- master
- Lint
Lint Passed - Unit
Test Failures - Build Status
Buildable 9041 Build 10629: arc lint + arc unit
Time | Test | |
---|---|---|
1,869 ms | ArcanistJSHintLinterTestCase::Unknown Unit Message (" |